Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At moonbeam we have worked on a
lazy-loading
feature which is a client mode that forks a live parachain and fetches its state on-demand, we have been able to do this by duplicating some code fromsc_service::client
. The objective of this PR is to simplify the implementation by making public some types in polkadot-sdk.sc_service::client
I do not see a point to only expose this type whentest-helpers
feature is enabledsc_service::client::WasmOverride
sc_service::client::WasmSubstitutes
sc_service::client::CodeProvider
Required after Unifycode_at
logic betweenCallExecutor
&Client
#4618In my opinion the advantages of making these types public is greater than keeping them as internals, since it gives more flexibility to devs when building their parachain clients.
Integration
Not applicable, the PR just makes some types public.
Review Notes
The changes included in this PR give more flexibility for client developers by exposing important types.